test: add ignore() context manager test coverage #832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ignore() tests to all test classes that previously only tested strict() - Use get_collections() for ignore() tests since it emits warnings (unlike search() which raises exceptions directly) - Achieve 100% coverage for warnings.py module
jsignell
requested changes
Sep 29, 2025
There was a problem hiding this comment.
Thanks for working on increasing the test coverage! But I don't think these make sense as additions to preexisting search API tests. Maybe they deserve their own class for get_collections. Also you might need to add an ignore to cover the ResourceWarning that is showing up in CI
- Add ignore() tests to all test classes that previously only tested strict() - Use get_collections() for ignore() tests since it emits warnings (unlike search() which raises exceptions directly) - Achieve 100% coverage for warnings.py module
Remove all ignore() test blocks that were mixed with API tests. These tests now belong in the dedicated test_warnings.py file.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #832 +/- ##
==========================================
+ Coverage 93.43% 95.06% +1.63%
==========================================
Files 13 15 +2
Lines 990 1217 +227
==========================================
+ Hits 925 1157 +232
+ Misses 65 60 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Ignore ResourceWarning and PytestUnraisableExceptionWarning to prevent CI failures from pre-existing unclosed socket warnings that are not related to our warning context manager tests.
nlebovits
force-pushed
the
lebovits/590-increase-test-coverage
branch
from
26bf119 to
5221373
Compare
Add entry documenting the comprehensive test coverage added for ignore() and strict() context managers in PR stac-utils#832.
jsignell
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
PR Checklist: